bug fix #105

app/controllers/admin/candidate_controller.rb

@@ -61,7 +61,7 @@ module Admin
       end
 
       def collect_quizzes
-        @quizzes ||= Quiz.order(:name)
+        @quizzes ||= Quiz.all_active.order(:name)
       end
 
       def send_notifications candidate

app/models/quiz.rb

@@ -8,4 +8,10 @@ class Quiz < ApplicationRecord
   validates :name, presence: true, uniqueness: true
   validates :dept, presence: true
   validates :unit, presence: true
+
+  class << self
+    def all_active
+      Quiz.joins(:questions).distinct
+    end
+  end
 end

test/fixtures/quizzes.yml

@@ -14,3 +14,8 @@ studio:
   name: Studio Screening One
   unit: PD Studio
   dept: FED
+
+empty_quiz:
+  name: A quiz with no questions
+  unit: PD
+  dept: FED

test/models/quiz_test.rb

@@ -2,7 +2,10 @@
 require 'test_helper'
 
 class QuizTest < ActiveSupport::TestCase
-  # test "the truth" do
-  #   assert true
-  # end
+  test "all_active only returns quizzes with questions" do
+    empty_quiz = quizzes(:empty_quiz)
+    quizzes = Quiz.all_active
+
+    refute quizzes.any? { |q| q.id == empty_quiz.id }
+  end
 end