review comment tweaks - completes #104

2017-03-07 16:35:59 -06:00
parent 2c0020a280
commit e0ff645926
6 changed files with 44 additions and 9 deletions
--- a/test/controllers/admin/vote_controller_test.rb
+++ b/test/controllers/admin/vote_controller_test.rb
@ -70,5 +70,16 @@ module Admin
      assert_equal 'ipsum', Candidate.find(henry.to_i).review_comments
      assert_redirected_to admin_result_url(henry.test_hash)
    end
+
+    test "approve fails without comment" do
+      auth_user users(:manager)
+      henry = candidates(:henry)
+
+      assert_enqueued_jobs 0 do
+        post admin_interview_url(henry.test_hash), params: { review_status: 'approved' }
+      end
+      assert_match 'comment', flash[:error]
+      assert_redirected_to admin_result_url(henry.test_hash)
+    end
  end
 end