mmoser/skill-assessment-app
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

rubocop noise: switched to predicate comparisons

Browse Source 
Also introduced because of .ruby-version specification

http://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Style/NumericPredicate
This commit is contained in:
Mark Moser 2016-09-08 10:39:26 -05:00
parent 4bbd93ded1
commit 9f23a5d3ce
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/controllers/candidate_controller.rb
View File

@ -12,7 +12,7 @@ class CandidateController < ApplicationController
end end
def welcome def welcome
render :welcome_back if current_candidate.answers.count > 0 render :welcome_back if current_candidate.answers.count.positive?
end end
def saved def saved

2
app/validators/input_options_presence_validator.rb
View File

@ -2,7 +2,7 @@
class InputOptionsPresenceValidator < ActiveModel::EachValidator class InputOptionsPresenceValidator < ActiveModel::EachValidator
def validate_each(record, attribute, value) def validate_each(record, attribute, value)
return true unless record.input_type =~ /radio|check/i return true unless record.input_type =~ /radio|check/i
return true if value.present? && value.count > 0 return true if value.present? && value.count.positive?
record.errors[attribute] << (options[:message] || record.errors[attribute] << (options[:message] ||
"You must provide answer options for the selected input type.") "You must provide answer options for the selected input type.")

2
app/workers/quiz_status.rb
View File

@ -7,7 +7,7 @@ class QuizStatus
end end
def started def started
candidate.answers.count > 0 candidate.answers.count.positive?
end end
def on_summary def on_summary