oauth cleanup: test fakes and generic provider

test/controllers/accounts_controller_test.rb

@@ -1,15 +1,16 @@
 require 'test_helper'
 
 class AccountsControllerTest < ActionDispatch::IntegrationTest
+  include TestAuthHelper
+
   setup do
+    get auth_path
     @account = accounts(:account1)
-    # get login_path
-    # session[:token] = 'fake-oauth-token'
-    # session[:name] = "Fake User"
   end
 
   test "should get index" do
     get accounts_url
+
     assert_response :success
   end
 

test/controllers/auth_controller_test.rb

@@ -1,8 +1,28 @@
 require 'test_helper'
 
 class AuthControllerTest < ActionDispatch::IntegrationTest
-  # test "should get auth" do
-  #   get auth_url
-  #   assert_response :redirect
-  # end
+  include TestAuthHelper
+
+  test "should get auth" do
+    # This is not a real test of AuthController!
+    # We are really testing that the monkey path is correct
+    #
+    # This simply tests to make sure the test suite is
+    # properly monkey patching the oAuth network call and
+    # faking the needed session variables.
+    #
+    # If you want to really test the oAuth flow you will need to
+    # hit the real services, or stand up a proper fake service.
+    get auth_path
+    assert_redirected_to accounts_path
+  end
+
+  test "should verify callbacks result" do
+    # If AuthController#callback ever changes final
+    # redirection, the patched version should also
+    # be updated in (lin e10) of
+    # test/test_helpers/test_auth_helper.rb
+
+    assert_equal "redirect_to accounts_path", last_line_in_callback
+  end
 end